Skip to content

feat(GenAI): Gemma2 samples for Model Garden deployments to Vertex AI endpoints #12598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 24, 2024
Merged

feat(GenAI): Gemma2 samples for Model Garden deployments to Vertex AI endpoints #12598

merged 8 commits into from
Sep 24, 2024

Conversation

rsamborski
Copy link
Member

Description

Fixes b/365590892

Gemma2 samples for Model Garden deployments to Vertex AI endpoints
Tests are mocked for now until we make a decision if we want to have these models permanently deployed for testing purposes.

Checklist

@rsamborski rsamborski requested review from a team as code owners September 17, 2024 13:57
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 17, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 17, 2024
@rsamborski rsamborski assigned msampathkumar and unassigned nicain Sep 17, 2024
@BigBlackWolf BigBlackWolf mentioned this pull request Sep 20, 2024
Merged
9 tasks
@gryczj gryczj mentioned this pull request Sep 20, 2024
Merged
10 tasks
This was referenced Sep 20, 2024
Merged
Closed
msampathkumar
msampathkumar approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar
Copy link
Member

quick question. For now we continue with gemma2 folder or We can use model_garden named folder in generativeai product folder

@rsamborski rsamborski merged commit f990c8a into main Sep 24, 2024
15 checks passed
@rsamborski rsamborski deleted the feat_gemma_sample branch September 24, 2024 09:23
@rsamborski rsamborski mentioned this pull request Sep 24, 2024
Merged
11 tasks
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
@rsamborski @riathakkar
feat(GenAI): Gemma2 samples for Model Garden deployments to Vertex AI…
39749b0 
… endpoints (GoogleCloudPlatform#12598)

* Initial working samples

* Tests ready with mocks

* Updated CODEOWNERS

* Fix lint and tests

* Fix lint and tests

* Moving samples to fix testing issues when in subfolder of generative-ai

* Add missing pytest

* Trailling newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@msampathkumar msampathkumar

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsamborski @msampathkumar @m-strzelczyk @nicain